TypeScript: support for "properties:static" #4312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafl
force-pushed
the
typescript-static-property
branch
2 times, most recently
from
21987b4 to
d656651
Compare
masatake
reviewed
Oct 13, 2025
parsers/typescript.c
Outdated
| } tsKind; | ||
|
|
||
| typedef enum { | ||
| F_STATIC, |
There was a problem hiding this comment.
"static" is one of the values that the properties field can take.
So, F_PROPERTIES is better. So, for example, we can append "inline" to the field.
There was a problem hiding this comment.
Should I fix this in jscript.c, too?
JavaScript: fix constant name to be consistent
jafl
force-pushed
the
typescript-static-property
branch
from
a3563a3 to
0d29c0b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4312 +/- ##
==========================================
- Coverage 85.88% 85.87% -0.01%
==========================================
Files 248 248
Lines 63602 63622 +20
==========================================
+ Hits 54624 54638 +14
- Misses 8978 8984 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I will take over this. |
|
See #4317. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
properties:static, like what I added to the JavaScript parserReplaces #4311